Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release commit V2.6.2 #77

Merged
merged 2 commits into from
May 17, 2019
Merged

Release commit V2.6.2 #77

merged 2 commits into from
May 17, 2019

Conversation

jaybyrrd
Copy link
Contributor

@jaybyrrd jaybyrrd commented May 13, 2019 •
edited
Loading

Issue #, if available: #67

Description of changes: Adds a changelog entry so that a release can be made.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@yogiraj07
Copy link
Contributor

yogiraj07 commented May 13, 2019 •
edited
Loading

Hi @jaybyrrd ,
Thank you for submitting the PR. The release commit includes change log as well as incrementing version per package: reference. Since this release contains change in core package, a patch release version bump is required for rest of the packages. For the moment, I would suggest not to include date in the changelog, since it reflects actual release date. I would make a separate commit for updating the date and version for the packages which will be called as a release commit.

Thanks,
Yogi

yogiraj07
yogiraj07 reviewed May 13, 2019
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
yogiraj07
yogiraj07 suggested changes May 14, 2019
View reviewed changes
Copy link
Contributor

@yogiraj07 yogiraj07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jaybyrrd ,

  1. Need to increment this package to 2.6.2 and update all necessary dependency version mentioned in this PR. This is a uber package which installs all X-Ray packages.

  2. Need to increment Core package to 2.5.2

sdk/src/Handlers/AspNet/AWSXRayRecorder.Handlers.AspNet.csproj Outdated Show resolved Hide resolved
sdk/src/Handlers/AspNetCore/AWSXRayRecorder.Handlers.AspNetCore.csproj Outdated Show resolved Hide resolved
sdk/src/Handlers/SqlServer/AWSXRayRecorder.Handlers.SqlServer.csproj Outdated Show resolved Hide resolved
sdk/src/Handlers/System.Net/AWSXRayRecorder.Handlers.System.Net.csproj Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
yogiraj07
yogiraj07 suggested changes May 16, 2019
View reviewed changes
sdk/AWSXRayRecorder.nuspec Outdated
<dependency id="AWSXRayRecorder.Handlers.SqlServer" version="2.5.1" />
<dependency id="AWSXRayRecorder.Handlers.System.Net" version="2.5.1" />
<dependency id="AWSXRayRecorder.Core" version="2.5.2" />
<dependency id="AWSXRayRecorder.Handlers.AspNet" version="2.5.2" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in the previous comment, don't need to increase version for AWSXRayRecorder.Handlers.AspNet package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, apologies for how many times I have done this slightly off!

sdk/src/Handlers/AspNet/AWSXRayRecorder.Handlers.AspNet.csproj Outdated Show resolved Hide resolved
@yogiraj07 yogiraj07 merged commit 91b6124 into aws:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yogiraj07 yogiraj07 yogiraj07 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaybyrrd @yogiraj07