Skip to content

fix: close AWS config#8134

Closed
testwill wants to merge 1 commit intoaws:mainfrom
testwill:close_file
Closed

fix: close AWS config#8134
testwill wants to merge 1 commit intoaws:mainfrom
testwill:close_file

Conversation

@testwill
Copy link
Copy Markdown

@testwill testwill commented May 10, 2024

Issue #, if available:

Description of changes:
close AWS config
Testing (if applicable):
test success
Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign d8660091 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Copy Markdown
Collaborator

Hi @testwill. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 10, 2024
@mitalipaygude
Copy link
Copy Markdown
Contributor

Can you update the description section of this PR? the testing part as well

if err != nil {
return nil, err
}
defer file.Close()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide more context in the PR description on why this is needed?

@abhay-krishna
Copy link
Copy Markdown
Contributor

@testwill Are you still working on this? Any updates from the last review?

@testwill
Copy link
Copy Markdown
Author

@testwill Are you still working on this? Any updates from the last review?

no

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants