Skip to content

Conversation

@booleanbetrayal
Copy link

@booleanbetrayal booleanbetrayal commented Jun 18, 2024

Issue

Lack of support for revisionHistoryLimit in aws-for-fluent-bit chart values / DaemonSet leads to potentially unnecessary / annoying clutter of revision sets.

Description of changes

Adds revisionHistoryLimit support in aws-for-fluent-bit with defaults set to K8s default, following the lead in aws-load-balancer-controller.

Checklist

  • Added/modified documentation as required (such as the README.md for modified charts)
  • Incremented the chart version in Chart.yaml for the modified chart(s)
  • Manually tested. Describe what testing was done in the testing section below
  • Make sure the title of the PR is a good description that can go into the release notes

Testing

helm template validation

  • By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

PettitWesley
PettitWesley previously approved these changes Jun 19, 2024
@booleanbetrayal
Copy link
Author

Thanks for the review @PettitWesley !

@booleanbetrayal
Copy link
Author

Just checking on what the merge criteria is now that this has been approved. Looking forward to de-cluttering!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants