Skip to content

Use popover instead of layer#707

Merged
kmcginnes merged 1 commit intoaws:mainfrom
kmcginnes:popover
Dec 9, 2024
Merged

Use popover instead of layer#707
kmcginnes merged 1 commit intoaws:mainfrom
kmcginnes:popover

Conversation

@kmcginnes
Copy link
Copy Markdown
Collaborator

@kmcginnes kmcginnes commented Dec 9, 2024

Description

Replace use of UseLayer component with Popover.

  • Remove UseLayer
  • Change z index and width of existing Popover styles
  • Update export options to set width
  • Update ColorInput to use Popover
  • Move color swatch out of adornment because adornment traps clicks and we want the swatch to be transparent to clicks

Validation

  • Smoke test color input in node & edge styling

Related Issues

Check List

  • I confirm that my contribution is made under the terms of the Apache 2.0
    license.
  • I have run pnpm checks to ensure code compiles and meets standards.
  • I have run pnpm test to check if all tests are passing.
  • I have covered new added functionality with unit tests if necessary.
  • I have added an entry in the Changelog.md.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 18.62%. Comparing base (9d3a2b7) to head (2dc4b0b).
Report is 49 commits behind head on main.

Files with missing lines Patch % Lines
...-explorer/src/components/ColorInput/ColorInput.tsx 0.00% 34 Missing ⚠️
packages/graph-explorer/src/components/Popover.tsx 0.00% 1 Missing ⚠️
...r/controls/ExportControl/ExternalExportControl.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #707      +/-   ##
==========================================
+ Coverage   14.88%   18.62%   +3.73%     
==========================================
  Files         566      534      -32     
  Lines       25121    23128    -1993     
  Branches     1170     1151      -19     
==========================================
+ Hits         3739     4307     +568     
+ Misses      21050    18552    -2498     
+ Partials      332      269      -63     
Flag Coverage Δ
unittests 18.62% <0.00%> (+3.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kmcginnes kmcginnes marked this pull request as ready for review December 9, 2024 17:29
@kmcginnes kmcginnes merged commit def1496 into aws:main Dec 9, 2024
@kmcginnes kmcginnes deleted the popover branch December 9, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants