Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implemented DescribeCluster to Discover Cluster Version #7314

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Implemented DescribeCluster to Discover Cluster Version #7314

wants to merge 19 commits into from
+127 −6

Conversation

edibble21
Copy link
Contributor

Fixes #N/A

Description
Implemented DescribeCluster to Discover Cluster Version

How was this change tested?
Make Presubmit
Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@netlify Netlify
Copy link

netlify bot commented Nov 1, 2024 •
edited
Loading

✅ Deploy Preview for karpenter-docs-prod canceled.

Name Link
🔨 Latest commit 56e6cd6
🔍 Latest deploy log https://app.netlify.com/sites/karpenter-docs-prod/deploys/6732a6bf2104bb0008be208c

@coveralls
Copy link

coveralls commented Nov 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11788639614

Details

  • 12 of 33 (36.36%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 82.59%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/operator.go 0 1 0.0%
pkg/errors/errors.go 0 9 0.0%
pkg/providers/version/version.go 10 21 47.62%
Files with Coverage Reduction New Missed Lines %
pkg/providers/version/version.go 1 58.62%
Totals Coverage Status
Change from base Build 11758502989: -0.2%
Covered Lines: 5683
Relevant Lines: 6881
💛 - Coveralls

edibble21
edibble21 commented Nov 1, 2024
View reviewed changes
Copy link
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/Karpenter Snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-ab0b79e210d19c91fab1636ad2ff1ba546351686.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-ab0b79e210d19c91fab1636ad2ff1ba546351686" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

edibble21
edibble21 commented Nov 1, 2024
View reviewed changes
Copy link
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-46bcd1049e4d9bdcda901d9d3d12ab92c6da97d0.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-46bcd1049e4d9bdcda901d9d3d12ab92c6da97d0" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

@edibble21 edibble21 marked this pull request as ready for review November 2, 2024 02:55
@edibble21 edibble21 requested a review from a team as a code owner November 2, 2024 02:55
edibble21
edibble21 commented Nov 2, 2024
View reviewed changes
Copy link
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Snapshot successfully published to oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter:0-4248b84b3ae228e00fa7826ae74c86b5a33eb08f.
To install you must login to the ECR repo with an AWS account:

aws ecr get-login-password --region us-east-1 | docker login --username AWS --password-stdin 021119463062.dkr.ecr.us-east-1.amazonaws.com

helm upgrade --install karpenter oci://021119463062.dkr.ecr.us-east-1.amazonaws.com/karpenter/snapshot/karpenter --version "0-4248b84b3ae228e00fa7826ae74c86b5a33eb08f" --namespace "kube-system" --create-namespace \
  --set "settings.clusterName=${CLUSTER_NAME}" \
  --set "settings.interruptionQueue=${CLUSTER_NAME}" \
  --set controller.resources.requests.cpu=1 \
  --set controller.resources.requests.memory=1Gi \
  --set controller.resources.limits.cpu=1 \
  --set controller.resources.limits.memory=1Gi \
  --wait

edibble21
edibble21 commented Nov 4, 2024
View reviewed changes
Copy link
Contributor Author

@edibble21 edibble21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/karpenter snapshot

njtran
njtran reviewed Nov 5, 2024
View reviewed changes
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Show resolved Hide resolved
jonathan-innis
jonathan-innis reviewed Nov 6, 2024
View reviewed changes
pkg/errors/errors.go Outdated Show resolved Hide resolved
pkg/errors/errors.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
pkg/providers/version/version.go Outdated Show resolved Hide resolved
jonathan-innis
jonathan-innis previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- it just needs a test now

pkg/providers/version/version.go Show resolved Hide resolved
njtran
njtran reviewed Nov 12, 2024
View reviewed changes
pkg/errors/errors.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran left review comments

@jonathan-innis jonathan-innis jonathan-innis left review comments

@ellistarn ellistarn Awaiting requested review from ellistarn ellistarn is a code owner automatically assigned from aws/karpenter

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@edibble21 @coveralls @njtran @jonathan-innis @shabbskagalwala @jigisha620