fix(s2n-quic-dc): Import fixes + new metrics #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This emits the metrics declared by the previous commit, and adjusts the path secret map accessors to fix a bug: This ensures that user-visible access to the ID map also populates the peer map, which helps avoid getting stuck server-side where we can't call handshake_with(...) but currently still need access by peer address; we previously resolved the case where the entry is hidden by requested_handshakes and this fixes where the entry is actually missing due to conflict eviction.
Mark-Simulacrum
changed the title
camshaft
approved these changes
Jan 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Description of changes:
Reviewed previously out of band (though re-review is probably a good idea to check the import was reasonable):
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.