-
Notifications
You must be signed in to change notification settings - Fork 715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PQ TLS 1.2 Support #4991
base: main
Are you sure you want to change the base?
Conversation
@@ -1000,6 +1000,34 @@ impl Connection { | |||
} | |||
} | |||
|
|||
pub fn kem_group_name(&self) -> Option<&str> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copy/Paste of kem_name
function a few lines above, but with a call to s2n_connection_get_kem_group_name()
instead of s2n_connection_get_kem_name()
.
600d533
to
9cf4622
Compare
/* Ensure that PQ enabled Policies support TLS 1.3 since TLS 1.3 is now required for PQ support. */ | ||
EXPECT_TRUE(has_tls_13_cipher); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved "TLS 1.3 + PQ checks" further down in the function so that this code has access to the has_tls_13_cipher
variable, so that a check that requires TLS 1.3 support for all PQ policies could be added.
9cf4622
to
61b66e5
Compare
61b66e5
to
6d988ce
Compare
…nd it results in a smaller diff
} | ||
|
||
const struct s2n_security_policy *security_policy = NULL; | ||
|
||
/* Test Deprecated Security Policies*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New unit tests for deprecated security policies.
Release Summary:
Removes draft support for post-quantum TLS 1.2 (draft-campagna-tls-bike-sike-hybrid) from s2n-tls. Support for post-quantum TLS 1.3 (draft-ietf-tls-hybrid-design) is kept.
Resolved issues:
None.
Description of changes:
Removes draft support for post-quantum TLS 1.2 (draft-campagna-tls-bike-sike-hybrid) from s2n-tls. Support for post-quantum TLS 1.3 (draft-ietf-tls-hybrid-design) is kept.
Call-outs:
TLS_ECDHE_KYBER_RSA_WITH_AES_256_GCM_SHA384
cipher entirely from s2n-tls.s2n_ecdhe_kyber_rsa_with_aes_256_gcm_sha384
was removed from all cipher preference lists. If this removal made the cipher preference list identical to an already existing cipher preference list, then the entire cipher preference list was deleted and security policies migrated to use the other already existing cipher preference list. Otherwise, if no equivalent cipher preference list existed thens2n_ecdhe_kyber_rsa_with_aes_256_gcm_sha384
was removed in-place (eg forcipher_suites_pq_tls_1_0_2021_05_24
).s2n_connection_get_kem_name()
is kept, but now hardcoded to always returnNONE
in all circumstances so as to not break customers.Testing:
S2N_ERR_DEPRECATED_SECURITY_POLICY
when requested.Remember:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.