feat: deprecate default tls13, pq policies - #6038
Open
jmayclin wants to merge 2 commits into
Open
Conversation
jouho
reviewed
Aug 17, 2026
Comment on lines
-13
to
-18
| - TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256 | ||
| - TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256 | ||
| - TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA384 | ||
| - TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384 | ||
| - TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256 | ||
| - TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256 |
Contributor
There was a problem hiding this comment.
Is this a safe change to make? If customers are using this policy and relying on CBC or ChaChaPolyciphers, won't removing them here break clients that only support those suites?
Contributor
Author
There was a problem hiding this comment.
In a way no, not a safe change to make. But the explicit stance of the default_* policies is that we do not promising stability for them.
Basically, this is the exact same tradeoff that we made when we dropped the old ciphers for our default policy. #5560
Contributor
There was a problem hiding this comment.
Ah true. Since this is a pretty large policy change, could we include a release note in the PR description?
jouho
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Make the
default_pqanddefault_tls13policies good.Why
default_tls13isn't currently PQ enabled.default_pqsupports CBC ciphers.How
Just alias everything to the
defaultpolicy.Callouts
This is a slight regression for the
default_tls13policy, which was previously rejecting SHA1 signatures on certificates. I think the PQ enablement is worth it.Although we should follow up with the removal of SHA1 signatures on the default cert preferences.
I will also be following up with a PR to clean up the TLS 1.3 default config spaghetti.
Testing
Had to update some security policy tests. All unit tests should pass. The previous
default_pqanddefault_tls13policies are negotiable with the currentdefault, so this is a safe change to make.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.