fix: initialize s2n_cert fields in s2n_connection_get_peer_cert_chain - #6045
Open
jouho wants to merge 1 commit into
Open
fix: initialize s2n_cert fields in s2n_connection_get_peer_cert_chain#6045jouho wants to merge 1 commit into
jouho wants to merge 1 commit into
Conversation
kaukabrizvi
approved these changes
Aug 18, 2026
jouho
enabled auto-merge
August 19, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Ensure
s2n_connection_get_peer_cert_chain()returns fully-initializeds2n_certnodes.Why
The function allocated each
s2n_certnode withs2n_alloc(which does not zero memory) and only set therawandnextfields. Thepkey_type,public_key, andinfofields were left as uninitialized heap bytes. Callers reading those fields (e.g. vias2n_cert_chain_and_key_get_pkey_type()) could leak heap residue or act on a garbage key type. The correct pattern was already used ins2n_create_cert_chain_from_stuffer().How
s2n_blob_zero(), so all fields have a defined value.infofor every cert, andpkey_type/public_keyfor the leaf cert, from the parsed X509, mirrorings2n_cert_chain_and_key_load().Callouts
An unknown leaf key type now fails with
S2N_ERR_CERT_TYPE_UNSUPPORTED, matchings2n_cert_chain_and_key_load().Testing
Existing
s2n_certificate_test(coverss2n_connection_get_peer_cert_chainsuccess/failure paths) ands2n_cert_validation_callback_testpass.Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.