fix: zero-initialize s2n_tls13_keys in PSK binder functions - #6048
Open
jouho wants to merge 1 commit into
Open
Conversation
jmayclin
approved these changes
Aug 18, 2026
jouho
enabled auto-merge
August 19, 2026 00:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Zero-initialize the
s2n_tls13_keysstack variables ins2n_psk_calculate_binderands2n_psk_verify_binder.Why
Without
= { 0 }, a partial-init failure ins2n_tls13_keys_init(e.g. an allocation failure ins2n_hmac_new) leaves the deferreds2n_tls13_keys_freeoperating on a partially-initialized struct, dereferencing an uninitializedhash_implpointer.How
Added
= { 0 }to bothDEFER_CLEANUPdeclarations so cleanup on the error path is safe-by-construction.Callouts
Matches the existing
s2n_tls13_connection_keyssafety pattern.Testing
Existing tests pass
Related
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.