-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use jumpstart deployment config image as default optimization image #4992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4992 +/- ##
=======================================
Coverage 86.55% 86.56%
=======================================
Files 438 438
Lines 42536 42584 +48
=======================================
+ Hits 36817 36862 +45
- Misses 5719 5722 +3 ☔ View full report in Codecov by Sentry. |
Lokiiiiii
suggested changes
Jan 14, 2025
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 14, 2025 18:00
2c7f025
to
068a8a7
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 14, 2025 18:05
068a8a7
to
19894ea
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 14, 2025 18:26
19894ea
to
3aaf596
Compare
cj-zhang
approved these changes
Jan 14, 2025
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 15, 2025 23:20
3aaf596
to
a1b0dc3
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 15, 2025 23:41
a1b0dc3
to
73696ba
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 16, 2025 00:50
73696ba
to
765e748
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 16, 2025 01:47
765e748
to
92477ff
Compare
Lokiiiiii
suggested changes
Jan 16, 2025
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 16, 2025 18:22
92477ff
to
311ad62
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 16, 2025 18:41
311ad62
to
d6f25d8
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 16, 2025 18:46
d6f25d8
to
1104baf
Compare
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 16, 2025 18:56
1104baf
to
7f5d892
Compare
Lokiiiiii
suggested changes
Jan 16, 2025
Lokiiiiii
approved these changes
Jan 17, 2025
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 17, 2025 17:57
66a1cdc
to
e610cc8
Compare
Integ tests r failing due to |
gwang111
force-pushed
the
js_optimiziation_image_defaults
branch
from
January 17, 2025 21:25
9d8344f
to
e610cc8
Compare
benieric
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
.optimize()
from the JumpStart deployment config in vLLM usecases.optimize()
Testing done:
Set
In the following instances:
Skip:
.optimize()
does not need to be called. No defaultingMerge Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.General
Tests
unique_name_from_base
to create resource names in integ tests (if appropriate)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.