Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use jumpstart deployment config image as default optimization image #4992

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

gwang111
Copy link
Collaborator

@gwang111 gwang111 commented Jan 13, 2025

Issue #, if available:

Description of changes:

  • Fetch the image uri default for .optimize() from the JumpStart deployment config in vLLM usecases
  • Update unit and integ tests to verify that the default is being propagated to .optimize()

Testing done:
Set

"ModelShardingConfig": {
    "Image": "dkr:jumpstart-deployment-config-image-uri"
}
or 
"ModelQuantizationConfig": {
    "Image": "dkr:jumpstart-deployment-config-image-uri"
}

In the following instances:

  1. When the customer wants to quantize their model
  2. When the customer wants to optimize with model sharding

Skip:

  1. For speculative decoding, .optimize() does not need to be called. No defaulting
  2. Skip configurations not supported by vLLM
  3. Skip for compilation as vLLM does not support compilation

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@gwang111 gwang111 requested a review from a team as a code owner January 13, 2025 22:46
@gwang111 gwang111 requested review from nileshvd, Lokiiiiii and cj-zhang and removed request for nileshvd January 13, 2025 22:46
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 94.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (7e5e69b) to head (427108f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/sagemaker/serve/builder/jumpstart_builder.py 94.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4992   +/-   ##
=======================================
  Coverage   86.55%   86.56%           
=======================================
  Files         438      438           
  Lines       42536    42584   +48     
=======================================
+ Hits        36817    36862   +45     
- Misses       5719     5722    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 2c7f025 to 068a8a7 Compare January 14, 2025 18:00
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 068a8a7 to 19894ea Compare January 14, 2025 18:05
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 19894ea to 3aaf596 Compare January 14, 2025 18:26
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 3aaf596 to a1b0dc3 Compare January 15, 2025 23:20
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from a1b0dc3 to 73696ba Compare January 15, 2025 23:41
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 73696ba to 765e748 Compare January 16, 2025 00:50
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 765e748 to 92477ff Compare January 16, 2025 01:47
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 92477ff to 311ad62 Compare January 16, 2025 18:22
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 311ad62 to d6f25d8 Compare January 16, 2025 18:41
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from d6f25d8 to 1104baf Compare January 16, 2025 18:46
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 1104baf to 7f5d892 Compare January 16, 2025 18:56
@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 66a1cdc to e610cc8 Compare January 17, 2025 17:57
@gwang111
Copy link
Collaborator Author

Integ tests r failing due to botocore.errorfactory.ResourceLimitExceeded exceptions

@gwang111 gwang111 force-pushed the js_optimiziation_image_defaults branch from 9d8344f to e610cc8 Compare January 17, 2025 21:25
@benieric benieric merged commit 51e4cc0 into master Jan 29, 2025
14 checks passed
@benieric benieric deleted the js_optimiziation_image_defaults branch January 29, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants