Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Omegaconf upgrade #4997

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Omegaconf upgrade #4997

merged 3 commits into from
Jan 17, 2025

Conversation

nargokul
Copy link
Contributor

@nargokul nargokul commented Jan 17, 2025

Issue #, if available:
Dependency was added as part of f28f814

Description of changes:
Omegaconf is not compatible with python 3.11. This adds the support .
https://conda-metadata-app.streamlit.app/?q=conda-forge%2Fnoarch%2Fomegaconf-2.2.3-pyhd8ed1ab_0.conda

Testing done:
Unit and Integ tests

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

nargokul and others added 3 commits December 20, 2024 09:31
# Conflicts:
#	src/sagemaker/serve/model_server/multi_model_server/inference.py
#	src/sagemaker/serve/model_server/torchserve/inference.py
#	src/sagemaker/serve/model_server/torchserve/xgboost_inference.py
@nargokul nargokul requested a review from a team as a code owner January 17, 2025 17:06
@nargokul nargokul requested a review from mohanasudhan January 17, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants