Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing attributes to local resourceconfig #4999

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

benieric
Copy link
Contributor

Issue #, if available:

Description of changes:

Testing done:

tox -e py310 -- -vv -s  tests/integ/test_local_mode.py::test_local_pipeline_with_step_decorator_and_step_dependency

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@benieric benieric requested a review from a team as a code owner January 21, 2025 22:03
@benieric benieric requested a review from Aditi2424 January 21, 2025 22:03
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 86.56%. Comparing base (0402ba0) to head (c1d9a4d).

Files with missing lines Patch % Lines
src/sagemaker/local/image.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4999   +/-   ##
=======================================
  Coverage   86.56%   86.56%           
=======================================
  Files         438      438           
  Lines       42536    42536           
=======================================
  Hits        36820    36820           
  Misses       5716     5716           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zhaoqizqwang
zhaoqizqwang previously approved these changes Jan 21, 2025
resource_config = {
"current_host": host,
"hosts": self.hosts,
"network_interface_name": "eth0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this always eth0 or can this be customized

Copy link
Contributor Author

@benieric benieric Jan 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is eth0 but not sure if can be customized. Even on platform training job can not customize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants