Repository navigation
Conversation
Replace the unconditional `@skipIf(True, ...)` on the tenancy config and NetworkConnector tests with per-region gating via `current_region_does_not_support`, so the tests run in regions where the corresponding Lambda features are available instead of never running. Adds the `MultiTenancy` and `NetworkConnector` service name constants. Verified in us-west-2: 3 passed - test_basic_function_with_tenancy_config - test_basic_network_connector - test_network_connector_with_custom_role
seshubaws
approved these changes
Oct 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available
N/A
Description of changes
test_basic_function_with_tenancy_configand theTestBasicNetworkConnectortests are currently skipped unconditionally with
@skipIf(True, ...), so theynever run anywhere.
This replaces those with the standard per-region gating the rest of the suite
uses, so each test runs in regions where the corresponding Lambda feature is
available and is skipped elsewhere:
test_basic_function_with_tenancy_config→MULTI_TENANCY(this just un-comments the
@skipIfthat was already there)TestBasicNetworkConnector→NETWORK_CONNECTORAdds the two matching constants to
integration/config/service_names.py.TestBasicMicroVMImageis intentionally left skipped — its templates pin amanaged base image ARN and version, which needs a separate fix.
Description of how you validated changes
Ran the affected tests against a real account in
us-west-2— 3 passed:test_basic_function_with_tenancy_configtest_basic_network_connectortest_network_connector_with_custom_roleruff checkandblack --checkpass.Checklist
Examples?
N/A
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.