Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor fixes and simplification of hybrid nodes upgrade instructions #882

Merged
merged 3 commits into from
Feb 28, 2025
Merged

Minor fixes and simplification of hybrid nodes upgrade instructions #882

merged 3 commits into from
Feb 28, 2025

Conversation

gauravpriyolkar
Copy link

@gauravpriyolkar gauravpriyolkar commented Feb 15, 2025 •
edited
Loading

Description of changes:

  • Simplified steps for marking a node as unschedulable by using cordon instead of adding taints. Also, uncordon step is missing in the in-place upgrade instructions on the live site, but I see it has been added recently to the markdown in git, but not yet published.
  • Fixed command for checking status of hybrid nodes after upgrade.
  • Fix command to identify all nodes of a particular Kubernetes version in cutover migration upgrade instructions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@aws-amplify-us-east-1 AWS Amplify (us-east-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-882.d3rijirjvbh87e.amplifyapp.com

@gauravpriyolkar gauravpriyolkar changed the title Minor fix and simplification of hybrid nodes upgrade instructions Minor fixes and simplification of hybrid nodes upgrade instructions Feb 15, 2025
@chrisnegus chrisnegus self-assigned this Feb 17, 2025
@pgasca pgasca requested review from chrisnegus and removed request for pgasca February 17, 2025 16:01
chrisnegus
chrisnegus approved these changes Feb 28, 2025
View reviewed changes
Copy link
Contributor

@chrisnegus chrisnegus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@chrisnegus chrisnegus merged commit e3eed53 into awsdocs:mainline Feb 28, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csplinter csplinter csplinter approved these changes

@chrisnegus chrisnegus chrisnegus approved these changes

Assignees

@chrisnegus chrisnegus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gauravpriyolkar @csplinter @chrisnegus