Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to hybrid nodes add-on docs #893

Merged
merged 4 commits into from
Feb 27, 2025
Merged

Conversation

erchpm
Copy link
Contributor

@erchpm erchpm commented Feb 25, 2025

Add Community add-ons table and metrics-server. Clarify routability requirements for add-ons that run webhooks.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Add Community add-ons table and metrics-server. Clarify routability requirements for add-ons that run webhooks.
@erchpm erchpm requested a review from pgasca as a code owner February 25, 2025 00:29
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-893.d3rijirjvbh87e.amplifyapp.com

@pgasca pgasca self-assigned this Feb 25, 2025

[cols="1,1", options="header"]
|===
|EKS add-on
|AWS Add-on
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't have "AWS" for branding reasons.

@pgasca pgasca assigned fincd-aws and unassigned pgasca Feb 25, 2025
@pgasca pgasca removed their request for review February 25, 2025 18:08
[#hybrid-nodes-add-ons-metrics-server]
=== Kubernetes Metrics Server add-on
The control plane needs to reach Metrics Server's pod IP (or node IP if hostNetwork is enabled). Therefore, unless you run Metrics Server in hostNetwork mode, you must configure a remote pod network when creating your Amazon EKS cluster, and you must make your pod IP addresses routable.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we list some options here for making pod IP routable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. When we call out pod routability, we should indicate that enabling BGP with your CNI is one popular way to do this.

Add reference to BGP for implementing pod IP routability for add-ons that require routable pod IPs.
Include CloudWatch webhook callout.
@erchpm erchpm changed the title Update hybrid-nodes-add-ons.adoc for metrics-server Add CloudWatch webhook callout Feb 27, 2025
@erchpm erchpm changed the title Add CloudWatch webhook callout Updates to hybrid nodes add-on docs Feb 27, 2025
@geoffcline
Copy link
Contributor

Thanks @erchpm ! I'm merging and building now. I may make some very limited changes internally.

@geoffcline geoffcline merged commit 9a53a46 into awsdocs:mainline Feb 27, 2025
2 checks passed
@geoffcline
Copy link
Contributor

Copilot Generated Summary:

This pull request includes several updates to the latest/ug/nodes/hybrid-nodes-add-ons.adoc file to improve clarity and provide additional information on compatible add-ons for Amazon EKS Hybrid Nodes. The most important changes include updating terminology, expanding compatibility information, and adding new sections for community add-ons.

Terminology updates:

  • Updated references from "Amazon EKS add-ons from {aws}" to "{aws} add-ons" for consistency. [1] [2]

Compatibility information:

  • Added a new section listing compatible community add-ons with Amazon EKS Hybrid Nodes.
  • Clarified that certain add-ons have anti-affinity rules to prevent them from running on hybrid nodes.

New sections:

  • Introduced a new section for the Kubernetes Metrics Server add-on, detailing the requirements for running it on hybrid nodes.

Other updates:

  • Changed the headings for various add-ons to use a consistent level of subheading. [1] [2] [3] [4]

pgasca pushed a commit that referenced this pull request Feb 28, 2025
* Update hybrid-nodes-add-ons.adoc for metrics-server

Add Community add-ons table and metrics-server. Clarify routability requirements for add-ons that run webhooks.

* Quick review of hybrid add-ons

* Add routability example

Add reference to BGP for implementing pod IP routability for add-ons that require routable pod IPs.

* Update hybrid-nodes-add-ons.adoc

Include CloudWatch webhook callout.

---------

Co-authored-by: Donovan Finch <[email protected]>

cr: https://code.amazon.com/reviews/CR-180771006
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants