-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to hybrid nodes add-on docs #893
Conversation
Add Community add-ons table and metrics-server. Clarify routability requirements for add-ons that run webhooks.
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
||
[cols="1,1", options="header"] | ||
|=== | ||
|EKS add-on | ||
|AWS Add-on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't have "AWS" for branding reasons.
[#hybrid-nodes-add-ons-metrics-server] | ||
=== Kubernetes Metrics Server add-on | ||
The control plane needs to reach Metrics Server's pod IP (or node IP if hostNetwork is enabled). Therefore, unless you run Metrics Server in hostNetwork mode, you must configure a remote pod network when creating your Amazon EKS cluster, and you must make your pod IP addresses routable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we list some options here for making pod IP routable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea. When we call out pod routability, we should indicate that enabling BGP with your CNI is one popular way to do this.
Add reference to BGP for implementing pod IP routability for add-ons that require routable pod IPs.
Include CloudWatch webhook callout.
Thanks @erchpm ! I'm merging and building now. I may make some very limited changes internally. |
Copilot Generated Summary: This pull request includes several updates to the Terminology updates: Compatibility information:
New sections:
Other updates: |
* Update hybrid-nodes-add-ons.adoc for metrics-server Add Community add-ons table and metrics-server. Clarify routability requirements for add-ons that run webhooks. * Quick review of hybrid add-ons * Add routability example Add reference to BGP for implementing pod IP routability for add-ons that require routable pod IPs. * Update hybrid-nodes-add-ons.adoc Include CloudWatch webhook callout. --------- Co-authored-by: Donovan Finch <[email protected]> cr: https://code.amazon.com/reviews/CR-180771006
Add Community add-ons table and metrics-server. Clarify routability requirements for add-ons that run webhooks.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.