Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combined permissions of Fargate logging into single step #895

Merged
merged 3 commits into from
Feb 25, 2025

Conversation

fincd-aws
Copy link
Contributor

Merge permissions steps 3 & 4 together, move IAM policy download down into this step as a new tabbed section.

The config file steps was too long and logically, the kubectl apply is the last sub-step, so the permissions were getting skipped by customers.

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Merge permissions steps 3 & 4 together, move IAM policy download down into this step as a new tabbed section.

The config file steps was too long and logically, the `kubectl apply` is the last sub-step, so the permissions were getting skipped by customers.
@fincd-aws fincd-aws requested a review from pgasca as a code owner February 25, 2025 17:43
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-895.d3rijirjvbh87e.amplifyapp.com

@pgasca pgasca self-assigned this Feb 25, 2025
@fincd-aws fincd-aws requested a review from a team as a code owner February 25, 2025 18:52
Verified that we are no longer using bolded "To do ___" intros for each tabbed list entry throughout guide.
Copy link
Contributor

@pgasca pgasca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, made small consistency tweaks.

@pgasca pgasca merged commit feb1bf6 into mainline Feb 25, 2025
3 checks passed
@fincd-aws fincd-aws deleted the fincd-fargate-logging branch February 25, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants