JavaScript (v3): Textract - Fix non-unique domain prefix in textract-react CFN template and some broke unit tests. #7190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Javascript-v3
rlhagerm
approved these changes
Jan 13, 2025
cpyle0819
changed the title
rlhagerm
approved these changes
Jan 14, 2025
Laren-AWS
added
On Call Review complete
…react CFN template.
…e working node engine.
[This PR](https://github.com/smithy-lang/smithy-typescript/pull/1490/files) overrode the default 'instanceof' implementation for ServiceException. It created a duck-type check that took priority over the prototype chain check. There's a [fix](https://github.com/smithy-lang/smithy-typescript/pull/1503/files) incoming, but in the meantime this makes it quack.
Laren-AWS
force-pushed
the
corepyle/textract-react
branch
from
f701281 to
f5bbc43
Compare
DavidSouther
pushed a commit
to prithugoswami/aws-doc-sdk-examples
that referenced
this pull request
Jan 22, 2025
…react CFN template and some broke unit tests. (awsdocs#7190) * JavaScript (v3): Textract - Fix non-unique domain prefix in textract-react CFN template. * JavaScript (v3): Textract - Update to latest react scripts and declare working node engine. * JavaScript (v3): Add workaround for broken instanceof check [This PR](https://github.com/smithy-lang/smithy-typescript/pull/1490/files) overrode the default 'instanceof' implementation for ServiceException. It created a duck-type check that took priority over the prototype chain check. There's a [fix](https://github.com/smithy-lang/smithy-typescript/pull/1503/files) incoming, but in the meantime this makes it quack. * JavaScript (v3): Textract - Ensure unique LoginUrl is saved as a CFN output. * JavaScript (v3): Unit tests - Fix incorrect link in S3 unit tests comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible customer issue. Non-unique name was causing stack creation to fail.
Also uncovered some unit tests that were breaking only with fresh node modules. There's a bug in the SDK that's actively being patched, but the unit test changes are a workaround.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.