Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java V2 update the S3 Java ListBuckets example #7192

Merged
merged 10 commits into from
Jan 29, 2025
Merged

Java V2 update the S3 Java ListBuckets example #7192

merged 10 commits into from
Jan 29, 2025

Conversation

scmacdon
Copy link
Contributor

This pull request updates the S3 Java ListBuckets example

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Bug An update to fix incorrect code or typos. labels Jan 13, 2025
@scmacdon scmacdon self-assigned this Jan 13, 2025
@scmacdon scmacdon requested a review from tkhill-AWS January 15, 2025 17:49
@scmacdon scmacdon added Internal To help track internal tickets in a single location. and removed Bug An update to fix incorrect code or typos. labels Jan 15, 2025
@tkhill-AWS
Copy link
Collaborator

More comments after second review.

tkhill-AWS
tkhill-AWS approved these changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@tkhill-AWS tkhill-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Jan 27, 2025
@rlhagerm rlhagerm added On Call Review complete On call review complete Bug An update to fix incorrect code or typos. and removed On Call Review needed This work needs an on-call review labels Jan 29, 2025
@rlhagerm rlhagerm merged commit a51baf9 into awsdocs:main Jan 29, 2025
19 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkhill-AWS tkhill-AWS tkhill-AWS approved these changes

@rlhagerm rlhagerm rlhagerm approved these changes

Assignees

@scmacdon scmacdon

Labels
Bug An update to fix incorrect code or typos. Internal To help track internal tickets in a single location. Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scmacdon @tkhill-AWS @rlhagerm