fix: clarify COMPLETED vs approved status on session resumption#255
Open
Abhishek8108 wants to merge 1 commit into
Open
fix: clarify COMPLETED vs approved status on session resumption#255Abhishek8108 wants to merge 1 commit into
Abhishek8108 wants to merge 1 commit into
Conversation
A fresh session reading aidlc-state.md could not distinguish between 'artifact generated' and 'user approved' when a stage shows COMPLETED, causing it to skip approval gates on resumption (issue awslabs#249). Add an explicit approval gate status table to session-continuity.md: - [x] Stage (Approved) → generated AND approved → proceed - [x] Stage (no tag) → generated only → halt and re-present artifact The new rules require the resuming session to halt at any stage marked COMPLETED without an (Approved) annotation, load the artifact, and request explicit user confirmation before continuing. An audit trail cross-check against audit.md is also specified as a tiebreaker. Fixes awslabs#249
Abhishek8108
requested review from
a team,
Kalindi-Dev,
harmjeff,
leandrodamascena,
raj-jain-aws,
scottschreckengaust and
spraja08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #249
Problem
When a session clears mid-workflow and a new instance resumes by reading
aidlc-state.md, it has no way to distinguish between:Both appear as
COMPLETEDin the state file, so the resumed session proceeds past approval gates without user confirmation — potentially generating later-stage artifacts before earlier ones have been reviewed.Fix
Adds an Approval Gate Status Interpretation section to
session-continuity.mdwith an explicit lookup table:[x] Stage Name (Approved)[x] Stage Name(no annotation)[ ] Stage NameThe rule is simple:
(Approved)annotation = safe to proceed; absent annotation = halt and re-present to the user before continuing. An audit trail cross-check viaaudit.mdis also specified as a tiebreaker when the state file is ambiguous.Scope
Single file change in
session-continuity.md— the file already referenced incore-workflow.mdas the mandatory guide for resumption. No other files touched.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.