Removed 2 unnecessary stubbings in AmazonSQSExtendedClientTest.java #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
In our analysis of the project, we observed that
1 stubbing which stubbed
putObjectis created inAmazonSQSExtendedClientTest.setupClientsbut is not executed by 14 tests:AmazonSQSExtendedClientTest. testWhenSendMessageWithLargePayloadSupportDisabledThenS3IsNotUsedAndSqsBackendIsResponsibleToFailItWithDeprecatedMethod,AmazonSQSExtendedClientTest. testReceiveMessageMultipleTimesDoesNotAdditionallyAlterReceiveMessageRequestWithDeprecatedMethod,AmazonSQSExtendedClientTest. testWhenSendSmallMessageThenS3IsNotUsed,AmazonSQSExtendedClientTest.testWhenSendMessageWithLargePayloadSupportDisabledThenS3IsNotUsedAndSqsBackendIsResponsibleToFailIt,AmazonSQSExtendedClientTest. testReceiveMessageMultipleTimesDoesNotAdditionallyAlterReceiveMessageRequest,AmazonSQSExtendedClientTest. testReceiveMessage_when_MessageIsLarge_legacyReservedAttributeUsed,AmazonSQSExtendedClientTest. testReceiveMessage_when_MessageIsLarge_ReservedAttributeUsed,AmazonSQSExtendedClientTest. testReceiveMessage_when_MessageIsSmall,AmazonSQSExtendedClientTest. testWhenSmallMessageIsSentThenNoAttributeIsAdded,AmazonSQSExtendedClientTest. testDefaultExtendedClientDeletesSmallMessage,AmazonSQSExtendedClientTest. testDefaultExtendedClientDeletesObjectS3UponMessageDelete,AmazonSQSExtendedClientTest. testExtendedClientConfiguredDoesNotDeleteObjectFromS3UponDelete,AmazonSQSExtendedClientTest. testExtendedClientConfiguredDoesNotDeletesObjectsFromS3UponDeleteBatch,AmazonSQSExtendedClientTest. testDefaultExtendedClientDeletesObjectsFromS3UponDeleteBatch.1 stubbing is created in
ChghostTest.getEventListenerbut is not executed by 5 tests:AmazonSQSExtendedClientTest. testDefaultExtendedClientDeletesSmallMessage,AmazonSQSExtendedClientTest. testDefaultExtendedClientDeletesObjectS3UponMessageDelete,AmazonSQSExtendedClientTest. testExtendedClientConfiguredDoesNotDeleteObjectFromS3UponDelete,AmazonSQSExtendedClientTest. testExtendedClientConfiguredDoesNotDeletesObjectsFromS3UponDeleteBatch,AmazonSQSExtendedClientTest. testDefaultExtendedClientDeletesObjectsFromS3UponDeleteBatch.Unnecessary stubbings are stubbed method calls that were never realized during test execution. Mockito recommends to remove unnecessary stubbings (https://www.javadoc.io/doc/org.mockito/mockito-core/latest/org/mockito/exceptions/misusing/UnnecessaryStubbingException.html).
We propose below a solution to remove the unnecessary stubbings.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.