Adding new logic to send user-agent in S3 Requests #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsengerG
reviewed
Jun 11, 2024
| public final class UserAgent { | ||
| // Hard-coded user-agent string | ||
| private static final String UA_STRING = "s3connectorframework"; | ||
| // TODO: Get VersionInfo and append it to UA. We need to understand how to create (if we want a) |
There was a problem hiding this comment.
So far our practice was to list code TODOs to Asana tickets. I believe we have a similar item already, let me dig it up for you.
There was a problem hiding this comment.
Might not be directly related, but similar: https://app.asana.com/0/1206885953994785/1207481230403504/f
fuatbasik
force-pushed
the
feature/add-user-agent
branch
2 times, most recently
from
6fdebd6 to
8defe77
Compare
With this commit, we will send s3connectorframework user-agent in every S3 request to help with observability. This commit also introduces ObjectClientConfiguration to let uses to prepend user-agent with custom values.
fuatbasik
force-pushed
the
feature/add-user-agent
branch
from
8defe77 to
6f98e6d
Compare
fuatbasik
force-pushed
the
feature/add-user-agent
branch
from
6f98e6d to
1ebd931
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this commit, we will send s3connectorframework user-agent in every S3 request to help with observability. This commit also introduces ObjectClientConfiguration to let uses to prepend user-agent with custom values.
Issue #, if available:
Description of changes:
1- Introducing a new configuration for ObjectClient that helps us to prepend User-Agent.
2- S3SDKObjectClient by default adds s3connectorframework:version-info (version to be decided) to the user agent.
3- Testing new user agent via unit tests. Note that there are no integration tests to confirm
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.