Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apple Network Framework SecItem #668

Open
wants to merge 463 commits into
base: grand_dispatch_queue
Choose a base branch
from
Open

Apple Network Framework SecItem #668

wants to merge 463 commits into from
+2,328 −511

Conversation

sbSteveK
Copy link
Contributor

Apple Network Framework SecItem implementation for iOS and tvOS

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sbSteveK sbSteveK changed the base branch from nw_socket to nw_socket_2 September 23, 2024 20:18
Base automatically changed from nw_socket_2 to nw_socket September 24, 2024 18:03
@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 32.00000% with 51 lines in your changes missing coverage. Please review.

Project coverage is 78.54%. Comparing base (43f1822) to head (350d00d).

Files with missing lines Patch % Lines
source/channel_bootstrap.c 25.00% 36 Missing ⚠️
source/tls_channel_handler.c 18.18% 9 Missing ⚠️
source/posix/socket.c 45.45% 6 Missing ⚠️
Additional details and impacted files 
@@                   Coverage Diff                    @@
##           grand_dispatch_queue     #668      +/-   ##
========================================================
- Coverage                 79.00%   78.54%   -0.47%     
========================================================
  Files                        30       30              
  Lines                      6322     6375      +53     
========================================================
+ Hits                       4995     5007      +12     
- Misses                     1327     1368      +41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sbSteveK added 21 commits November 4, 2024 13:22
@sbSteveK
move around some declarations
5030dee
@sbSteveK
secitem allows import of cert/key
7cf8376
@sbSteveK
another test that requires entitlements
4e45818
@sbSteveK
split out the tls block of parameters
df15054
@sbSteveK
s_setup_tls_options needs to be wrapped in ifdef Secitem
649d554
@sbSteveK
simplify parameters logic
b3b6645
@sbSteveK
SecItem does not use tls channel statistics
b7882f9
@sbSteveK
allow passing of an event loop into a server listener bind
e875822
@sbSteveK
forgot iocp socket_bind
8674aa7
@sbSteveK
missed it
1efece0
@sbSteveK
cleanup and test fix for windows
e66a9a6
@sbSteveK
restore s2n in cmakelists
6836232
@sbSteveK
aws_apple_network_framework.h should only be used with Apple OS
b4c9306
@sbSteveK
documentation
79ba389
@sbSteveK
more documentation and logic simplification
32ea35d
@sbSteveK
cleanup
0ba007b
@sbSteveK
simplify tls error_code reporting in channel bootstrap
565de94
@sbSteveK
documentation and reorder
b7b96ca
@sbSteveK
documentation and cleanup
31eab1e
@sbSteveK
unify tls options from context
bf4680a
@sbSteveK
remove unecessary check
bd6d2da
@sbSteveK sbSteveK marked this pull request as ready for review November 8, 2024 17:31
bretambrose
bretambrose reviewed Mar 6, 2025
View reviewed changes
sbSteveK and others added 25 commits March 7, 2025 14:45
@sbSteveK
initial code review changes
c56e5a0
@sbSteveK
no error overlap in checked errors
d584a98
@sbSteveK
fix windows iocp socket
f679925
@sbSteveK
fix windows test
f7f798b
@sbSteveK
fix windows test
62d5790
@sbSteveK
&
e30af6f
@xiazhvera
improve socket README
43ce9ea
@xiazhvera
fix tcp keepalive value
a7fd767
@sbSteveK
use a function/bool for secitem branching
cb09c0b
@sbSteveK
secitem_options is no longer a pointer
4f99093
@sbSteveK
PR changes: reorders and error on secondary setup of tls
9f93834
@sbSteveK
pull state change ready out into its own function
5634d79
@sbSteveK
improve socket state logging
936509b
@sbSteveK
merge with latest ns_socket
09dc97a
@sbSteveK
fatal assert fix
ee46e19
@xiazhvera
improve base socket lock & code review update
03c520e
@sbSteveK
add separate logging for prev vs secitem import of pkcs12
bcf3687
@xiazhvera
move shared args to private header
07b2adf
@xiazhvera
remove memcpy
f512314
@xiazhvera
improve error print
6bd46ab
@sbSteveK
merge with latest nw_socket
2855e35
@sbSteveK
merge fix
4e71d87
@sbSteveK
improve error reporting, state, and other logging
a2fdef2
@sbSteveK
rename aws_nw_socket_state enums with prefix
cf46aeb
@sbSteveK
Secitem Testing (#715)
e80c20f 
* Add CI Job that tests SecItem on macOS
* Fix/improve logging when using Apple Network Framework Sockets
* FIx error reporting when using SecItem with a TLS Negotiation error
Base automatically changed from nw_socket to grand_dispatch_queue March 17, 2025 17:14
@lauzadis lauzadis mentioned this pull request Mar 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bretambrose bretambrose bretambrose left review comments

@graebm graebm Awaiting requested review from graebm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sbSteveK @codecov-commenter @bretambrose @xiazhvera