Let mqtt.js auto-assign a client id #537
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt id and hanging the client when clean session is false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rather than passing an empty client id and hanging the client when clean session is false
Per follow-ups on #536, MQTT.js will refuse to connect if client id is empty (using auto-assigned client id), and clean session is false. By instead letting undefined by passed as the client id, mqtt.js will auto-assign a client id for us which lets us avoid a dependency on uuid.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.