Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linker flag fatal_warnings ought to be fatal-warnings #366

Closed
hxw opened this issue Jun 22, 2022 · 2 comments
Closed

Linker flag fatal_warnings ought to be fatal-warnings #366

hxw opened this issue Jun 22, 2022 · 2 comments
Labels
p2 This is a standard priority issue

Comments

@hxw
Copy link

hxw commented Jun 22, 2022

This line cause linker Error when compiling with clang:

ld: error: unknown argument '-fatal_warnings', did you mean '-fatal-warnings'

aws-crt-python/setup.py

Line 318 in e07efb4

extra_link_args += ['-Wl,-fatal_warnings']

according to the ld man page (both clang and GNU) this should be fatal-warnings
@timblaktu timblaktu mentioned this issue Sep 3, 2022
Closed
@timblaktu
Copy link

I'm stumbling over this too, @hxw, tracked it down to this commit. I'm going to try to fork and fix..

@timblaktu timblaktu mentioned this issue Sep 3, 2022
Closed
missingcharacter added a commit to missingcharacter/termux-dot-files that referenced this issue Sep 8, 2022
@missingcharacter
Temporarily install awscrt==0.13.0
d2e5ee2 
Until awslabs/aws-crt-python#366 is solved
@missingcharacter missingcharacter mentioned this issue Sep 8, 2022
Merged
@yasminetalby yasminetalby added the p2 This is a standard priority issue label Jun 26, 2023
@bretambrose
Copy link
Contributor

The additional platform checks around the variants of that linker flag should address this. Reopen if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p2 This is a standard priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hxw @bretambrose @timblaktu @yasminetalby