Temporarily install awscrt==0.13.0 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until awslabs/aws-crt-python#366 is solved
|
Also thanks to awsdocs/aws-cli-user-guide#11 (comment) |
timblaktu
suggested changes
Sep 8, 2022
| $ cd aws-cli | ||
| $ git checkout v2 | ||
| $ pkg install git python rust build-essential | ||
| $ git clone -b v2 https://github.com/aws/aws-cli.git | ||
| $ python -m venv venv |
There was a problem hiding this comment.
This mostly looks good to me, I like these simplifications. What is the virtual environment needed for? Aren't these instructions indicating how to build and install aws-cli v2 in a termux environment? It looks to me like you're installing into a virtual environment.
There was a problem hiding this comment.
@timblaktu I prefer using a virtual environment to avoid polluting my system.
Also, this helps me avoid running into dependency hell in case 2 different projects have similar dependencies but require incompatible versions between them.
There was a problem hiding this comment.
Thats sensible - I'm using poetry for python project deps.
timblaktu
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until awslabs/aws-crt-python#366 is solved
To address #1
What do you think @timblaktu