-
Notifications
You must be signed in to change notification settings - Fork 45
H2 write stream #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
H2 write stream #635
Conversation
…nto h2-write-stream
This class extends HttpClientConnection with HTTP/2 specific functionality. | ||
""" | ||
@classmethod | ||
def new(cls, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debatable: not sure it's worth giving this an explicit constructor? It's not doing anything to actually cause the user to get an HTTP/2 connection, like setting alpn=h2 or prior_knowledge_http2. It's just forcing an error if the user didn't end up getting an HTTP/2 connection.
For better or worse, our API in C takes all possible options, because it's possible to kick off a connection and not know what you're going to get at the end.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will add more to the connection, like settings, in the near future.
Issue #, if available:
Description of changes:
aws_py_translate_py_error
, clearly don'tset_sys_last_vars
. Since theset_sys_last_vars
will leave the exception (traceback) object live in the sys level, and somehow it may refer to the CRT native objects, and causing the test to leak. (which in theory, it's probably fine?)aws_http2_stream_write_data
to avoid every ticket of the loop to check the input stream for more data. It will wait until the next available input stream to read from it, which reduces the CPU usage.Key Design options
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.