make_request implementation #644
Merged
+735
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
April 7, 2025 13:22
sfod
approved these changes
Apr 15, 2025
| response_paths, allocator, (size_t)path_count, sizeof(struct aws_request_response_path)); | ||
|
|
||
| for (size_t i = 0; i < (size_t)path_count; ++i) { | ||
| PyObject *entry_py = PySequence_GetItem(response_paths_py, i); |
There was a problem hiding this comment.
Does PySequence_GetItem set the error indicator on failure? Quick googling didn't help me.
If not, we should set it ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.