-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cxx support #294
base: main
Are you sure you want to change the base?
Add cxx support #294
Conversation
Thank you for creating the PR. These changes will need to happen in the submodules first. I have created a PR at awslabs/aws-c-common#1160 that solves this problem a bit differently. Once that is approved and merged, I will create PRs for the remaining submodules. |
@waahm7 Thank you so much for quick response. Can I create PRs for other submodules to be followed by myself? |
@subdiox Sure, we will also need a CI job that tests crt-swift with cxx-interop before the final merge. |
@waahm7 I put up three PRs regarding the submodules. Could you review them if possible? |
@subdiox Thanks, I have merged all three PRs. We should use the latest submodules in this PR and a test for the cxx interop. |
@waahm7 I have rebased the submodules to update the related ones to the HEAD |
@subdiox We will also need to update CI to test the cxx interop before we can merge this. |
@waahm7 Should I add |
Issue #, if available: #166
Description of changes: This PR fixes the build error which occurs when it's built using Swift Package Manager (SPM) with C++ interoperability mode enabled.
Following changes were made:
AWS_NO_STATIC_IMPL
is defined when it's built with C++ complier.template
keyword as a variable nameDev Test:
I have confirmed that this package could be built successfully with C++ interoperability enabled.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.