Skip to content

Commit

Permalink
addressed lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
HarshGandhi-AWS committed Jul 5, 2023
1 parent 6eb723b commit 926147b
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 20 deletions.
2 changes: 1 addition & 1 deletion test/config/TestConfig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class ConfigTestFixture : public ::testing::Test

void SetUp() override
{
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
resourceManager.initializeAllocator();

// Config::Validate will check that cert, key, and root-ca files exist.
Expand Down
2 changes: 1 addition & 1 deletion test/config/TestConfigSerialization.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ TEST(SerializeConfigTestFixture, SerializeConfigTest)
]
}
})";
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();
PlainConfig config;
Expand Down
2 changes: 1 addition & 1 deletion test/devicedefender/TestDeviceDefender.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ class TestDeviceDefender : public testing::Test
{
deviceDefender = unique_ptr<MockDDFeature>(new MockDDFeature());
manager = shared_ptr<SharedCrtResourceManager>(new SharedCrtResourceManager());
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
manager->initializeAllocator();

notifier = shared_ptr<MockNotifier>(new MockNotifier());
Expand Down
4 changes: 2 additions & 2 deletions test/fleetprovisioning/TestFleetProvisioning.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ TEST(FleetProvisioning, EmptyTemplateParameters)
TEST(FleetProvisioning, MalformedTemplateParameters)
{
Aws::Iot::DeviceClient::SharedCrtResourceManager resourceManager;
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
resourceManager.initializeAllocator();

Aws::Crt::Optional<std::string> params("{\"SerialNumber\" \"Device-SN\"}"); // test missing colon
Expand All @@ -36,7 +36,7 @@ TEST(FleetProvisioning, MalformedTemplateParameters)
TEST(FleetProvisioning, ValidTemplateParameters)
{
Aws::Iot::DeviceClient::SharedCrtResourceManager resourceManager;
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
resourceManager.initializeAllocator();

Aws::Crt::Optional<std::string> params("{\"SerialNumber\": \"Device-SN\"}"); // test single JSON property
Expand Down
16 changes: 8 additions & 8 deletions test/jobs/TestJobDocument.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -173,7 +173,7 @@ TEST(JobDocument, SampleJobDocument)
}
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -382,7 +382,7 @@ TEST(JobDocument, MissingRequiredFields)
}
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -439,7 +439,7 @@ TEST(JobDocument, MinimumJobDocument)
]
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -536,7 +536,7 @@ TEST(JobDocument, MissingRequiredFieldsValue)
}
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -567,7 +567,7 @@ TEST(JobDocument, CommandFieldsIsEmpty)
]
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -598,7 +598,7 @@ TEST(JobDocument, CommandContainsSpaceCharacters)
]
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -629,7 +629,7 @@ TEST(JobDocument, SpaceCharactersContainedWithinFirstWordOfCommand)
]
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand All @@ -651,7 +651,7 @@ TEST(JobDocument, oldJobDocumentCompatibility)
"path": "default"
})";

//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down
2 changes: 1 addition & 1 deletion test/jobs/TestJobsFeature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ class TestJobsFeature : public ::testing::Test
public:
void SetUp()
{
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
resourceManager.initializeAllocator();

ThingName = Aws::Crt::String("thing-name value");
Expand Down
4 changes: 2 additions & 2 deletions test/shadow/TestConfigShadowFeature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ TEST(ConfigShadowFeature, resetClientConfigWithValidJSON)
})";

SharedCrtResourceManager resourceManager;
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
resourceManager.initializeAllocator();

JsonObject oldJsonObject(oldJsonString);
Expand Down Expand Up @@ -154,7 +154,7 @@ TEST(ConfigShadowFeature, resetClientConfigWithInvalidJSON)
}
})";
SharedCrtResourceManager resourceManager;
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
resourceManager.initializeAllocator();

JsonObject oldJsonObject(oldJsonString);
Expand Down
2 changes: 1 addition & 1 deletion test/tunneling/TestSecureTunnelingFeature.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ class TestSecureTunnelingFeature : public testing::Test
void SetUp() override
{
manager = shared_ptr<SharedCrtResourceManager>(new SharedCrtResourceManager());
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
manager->initializeAllocator();

thingName = Aws::Crt::String("thing-name value");
Expand Down
2 changes: 1 addition & 1 deletion test/util/TestSharedResourceManager.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ class SharedResourceManagerTest : public ::testing::Test

void SetUp() override
{
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
manager.initializeAllocator();

// SharedCrtResourceManager::locateCredentials will check that cert, key files
Expand Down
4 changes: 2 additions & 2 deletions test/util/TestStringUtils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ TEST(StringUtils, leavesNewLineAndTabAlone)

TEST(StringUtils, maptoString)
{
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down Expand Up @@ -136,7 +136,7 @@ TEST(StringUtils, ParseToStringVector)
{
"args": ["hello", "world"]
})";
//Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
// Initializing allocator, so we can use CJSON lib from SDK in our unit tests.
SharedCrtResourceManager resourceManager;
resourceManager.initializeAllocator();

Expand Down

0 comments on commit 926147b

Please sign in to comment.