Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdlf-team] handling of storage parameters #492

Merged
merged 1 commit into from
Nov 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions sdlf-team/src/team.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,14 @@ Parameters:
pPipelineReference:
Type: String
Default: none
pStorageDeploymentInstance:
Type: String
Description: The string uniquely identifying a sdlf-foundations deployment in this AWS account
Default: "" # see below comments
pAthenaBucket:
Description: S3 Athena bucket
Description: Athena bucket "{{resolve:ssm:/sdlf/storage/rAthenaBucket/dev}}"
Type: String
Default: "{{resolve:ssm:/sdlf/storage/rAthenaBucket/dev}}"
Default: "" # if not provided, pStorageDeploymentInstance must be specified
# pSNSNotificationsEmail:
# Description: Email address for SNS notifications
# Type: String
Expand All @@ -19,6 +23,9 @@ Parameters:
Type: String
AllowedPattern: "[a-z0-9]{2,12}"

Conditions:
FetchFromStorageSsm: !Not [!Equals [!Ref pStorageDeploymentInstance, ""]]

Resources:
######## KMS #########
rKMSInfraKey:
Expand Down Expand Up @@ -145,7 +152,7 @@ Resources:
EncryptionConfiguration:
EncryptionOption: SSE_KMS
KmsKey: !GetAtt rKMSInfraKey.Arn
OutputLocation: !Sub s3://${pAthenaBucket}/${pTeamName}/
OutputLocation: !If [FetchFromStorageSsm, !Sub "s3://{{resolve:ssm:/sdlf/storage/rAthenaBucket/${pStorageDeploymentInstance}}}/${pTeamName}/", !Sub "s3://${pAthenaBucket}/${pTeamName}/"]

rAthenaWorkgroupSsm:
Type: AWS::SSM::Parameter
Expand Down
Loading