-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EKS Cluster Compositions using upbound-aws-provider #201
base: main
Are you sure you want to change the base?
Conversation
Thank you for this PR @hflobao! |
@candonov , I've added claims for both EKS compositions. |
@hflobao -- great work! how about creating the networking infrastructure (VPC, subnets, etc.) as part of the composition? I think we should make it easy for users to experiment with this composition; asking them to create the networking infrastructure themselves, then passing the subnet ids in the claim may discourage them from trying the composition. The other option is modify the instructions in the README to patch the claims YAML with the ids of the existing subnets via snippets that users can easily copy/paste. What do you think? |
Hi @iamahgoub |
Hi @hflobao, |
What does this PR do?
This PR adds 2 compositions to create EKS clusters.
Motivation
#164
More
Yes, I have tested the PR using my local account setup (Provide any test evidence report under Additional Notes)
Yes, I have added a new example under examples to support my PR
Yes, I have updated the docs for this feature
Yes, I have linked to an issue or feature request (applicable to PRs that solves a bug or a feature request)
Note:
For Moderators
Additional Notes