fixed issue #271: Histogram analyzer filter missing #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting the change. Could you check if you can add a test case around here: |
|
@pwzhong friendly ping. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #, if available: #271
Description of changes:
Added the missing filter to Histogram analyzer in AnalysisResultSerde.scala, so that Histogram metrics with filter can be stored in the repository.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
P.S. The issue was opened last year and unfortunately I haven't got a chance to submit a PR. Recently, I checked the latest build that this bug still exists, so I submit it this time. I was also thinking about if a test case is needed. In AnalysisResultSerdeTest.scala, it seems nowhere to fit in such a use case. Please let me know if any suggestion. Thanks.