Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Spark SQL isNull check with Spark Scala based DSL #493

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Replace Spark SQL isNull check with Spark Scala based DSL #493

merged 1 commit into from
Jul 5, 2023

Conversation

rdsharma26
Copy link
Contributor

@rdsharma26 rdsharma26 commented Jul 5, 2023 •
edited
Loading

Issue

  • The column profiling for min/max lengths for a string column is not working when the column name has a space in it.

Description of changes:

  • Replaced Spark SQL isNull check with Spark Scala based DSL
  • This is to ensure columns with spaces in their names get their names escaped correctly in the where condition.
  • Added a test to verify.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rdsharma26
Replace Spark SQL isNull check with Spark Scala based DSL
69375e6 
- This is to ensure columns with spaces in their names get their names escaped correctly in the where condition.
- Added a test to verify.
eycho-am
eycho-am approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@eycho-am eycho-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rdsharma26 rdsharma26 merged commit f53283e into awslabs:master Jul 5, 2023
1 check passed
@rdsharma26 rdsharma26 deleted the fix-column-space-min-max-length branch July 5, 2023 21:08
rdsharma26 added a commit that referenced this pull request Jul 5, 2023
@rdsharma26
Replace Spark SQL isNull check with Spark Scala based DSL (#493)
22a2617 
- This is to ensure columns with spaces in their names get their names escaped correctly in the where condition.
- Added a test to verify.
rdsharma26 added a commit that referenced this pull request Apr 16, 2024
@rdsharma26
Replace Spark SQL isNull check with Spark Scala based DSL (#493)
1ace7dc 
- This is to ensure columns with spaces in their names get their names escaped correctly in the where condition.
- Added a test to verify.
rdsharma26 added a commit that referenced this pull request Apr 16, 2024
@rdsharma26
Replace Spark SQL isNull check with Spark Scala based DSL (#493)
1e1d812 
- This is to ensure columns with spaces in their names get their names escaped correctly in the where condition.
- Added a test to verify.
rdsharma26 added a commit that referenced this pull request Apr 16, 2024
@rdsharma26
Replace Spark SQL isNull check with Spark Scala based DSL (#493)
638dce9 
- This is to ensure columns with spaces in their names get their names escaped correctly in the where condition.
- Added a test to verify.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eycho-am eycho-am eycho-am approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rdsharma26 @eycho-am