Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test for desc #151

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ryota-sakamoto
Copy link
Contributor

Issue #, if available:

#143

Description of changes:

I have added the test for dy desc because the test is nothing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ryota-sakamoto ryota-sakamoto force-pushed the integration-test-desc branch 2 times, most recently from b33a167 to cd2037d Compare August 15, 2023 07:49
@ryota-sakamoto ryota-sakamoto marked this pull request as ready for review August 15, 2023 13:59
@kzym-w kzym-w self-requested a review August 24, 2023 09:16
Copy link
Contributor

@kzym-w kzym-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I already checked it worked on my env.

@kzym-w kzym-w merged commit 0350e39 into awslabs:main Aug 24, 2023
1 check passed
@kzym-w
Copy link
Contributor

kzym-w commented Aug 24, 2023

@ryota-sakamoto I'm very sorry but may I revert the merge? I overlooked that you need to modify second args for create_temporary_table for this change fa997ea#diff-35c83ed911ebb5eedc62f182cddb8cbc0ef0f5b7c7ca5bb3cc14cca373b22f5d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants