test: add integration test for admin desc #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmyoda
force-pushed
the
integration-test-admin-desc
branch
from
4d74ffc
to
430e1ed
Compare
23 tasks
wafuwafu13
requested changes
Sep 10, 2023
|
|
||
| #[tokio::test] | ||
| async fn test_admin_desc_table_from_options() -> Result<(), Box<dyn std::error::Error>> { | ||
| let table_name = util::create_temporary_table("pk,S", Some("sk,N")).await?; |
There was a problem hiding this comment.
[memo]
fixed arguments at #160
tests/admin_desc.rs
Outdated
|
|
||
| #[tokio::test] | ||
| async fn test_admin_desc_all_tables() -> Result<(), Box<dyn std::error::Error>> { | ||
| let table_name = util::create_temporary_table("pk", None).await?; |
There was a problem hiding this comment.
I think multiple tables (at least 2) are needed for testing --all-tables can describe all tables
There was a problem hiding this comment.
Thank you for your comment.
I've added 2 tables to this case to better validate the --all-tables.
tmyoda
force-pushed
the
integration-test-admin-desc
branch
from
430e1ed
to
a558d40
Compare
wafuwafu13
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#143
Description of changes:
I have added the test for
dy admin desc.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.