implement new parsing into put command #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StoneDot
force-pushed
the
improve-parsing-put
branch
2 times, most recently
from
d9f466c
to
e882903
Compare
tmyoda
reviewed
Oct 7, 2023
Introduce pest parsing into put command. This commit adds new features and breaking changes, but not limited to, * Support binary types. * Support single quotes for a string type. * Support explicit set types. However, it no longer supports the inference of set type when using `[elem]` because we can now specify set type explicitly using `<<elem>>` literal. BREKING CHANGE: put command no longer infers a set type.
StoneDot
force-pushed
the
improve-parsing-put
branch
from
e882903
to
96eea50
Compare
|
@tmyoda Thank you for your review. I made fixes based on your comments. Could you check these modifications? |
tmyoda
approved these changes
Oct 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Solve #162
Description of changes:
Introduce pest parsing into put command. This commit adds new features and breaking changes but not limited to,
However, it no longer supports the inference of set type when using
[elem]because we can now specify set type explicitly using<<elem>>literal.BREKING CHANGE: put command no longer infers a set type.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.