Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test for export #181

Merged
merged 1 commit into from
May 14, 2024

Conversation

ryota-sakamoto
Copy link
Contributor

@ryota-sakamoto ryota-sakamoto commented Oct 1, 2023

Issue #, if available:

#143

Description of changes:

I have added the test for dy export because the test is nothing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ryota-sakamoto ryota-sakamoto force-pushed the integration-test-export branch 3 times, most recently from eb951ae to 0f9e140 Compare November 18, 2023 04:57
@StoneDot StoneDot added the test Something related to test label Mar 1, 2024
@ryota-sakamoto ryota-sakamoto force-pushed the integration-test-export branch 3 times, most recently from 4dc710f to 87467e0 Compare May 13, 2024 14:31
@ryota-sakamoto ryota-sakamoto marked this pull request as ready for review May 13, 2024 15:36
@ryota-sakamoto ryota-sakamoto requested a review from a team as a code owner May 13, 2024 15:36
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for creating tests for the export command. I left a comment suggesting clarifying the test's meaning.
Could you please take a look at it?

tests/export.rs Show resolved Hide resolved
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding tests. Great job! I will approve this PR.

@StoneDot StoneDot merged commit 54d31f9 into awslabs:main May 14, 2024
4 of 5 checks passed
KIrie-0217 pushed a commit to KIrie-0217/dynein that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Something related to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants