Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependabot): remove auto dev deps upgrade #867

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Dec 31, 2024

Fixes #

Removes custom dependabot update dev dependencies since it is managed by projen (depsUpgrade is set to true in the projen project conf by default).
Created PRs through that custom add-on conflicts with the way dependencies are managed


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (1dc2673) to head (36a1221).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   95.93%   95.60%   -0.33%     
==========================================
  Files          61       61              
  Lines       20608    20608              
  Branches      615      592      -23     
==========================================
- Hits        19771    19703      -68     
- Misses        837      905      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: github-actions <[email protected]>
@krokoko
Copy link
Collaborator Author

krokoko commented Dec 31, 2024

Need to merge #866 first

@krokoko krokoko marked this pull request as draft December 31, 2024 01:17
@krokoko krokoko marked this pull request as ready for review December 31, 2024 01:27
Copy link
Member

@anitalewis anitalewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

mergify bot commented Dec 31, 2024

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #867 has been dequeued. The pull request could not be merged. This could be related to an activated branch protection or ruleset rule that prevents us from merging. (detail: You're not authorized to push to this branch. Visit https://docs.github.com/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches for more information.)

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@krokoko krokoko merged commit fb6e059 into main Dec 31, 2024
23 of 26 checks passed
@krokoko krokoko deleted the dependabot_dev_updates branch December 31, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants