[GSProcessing] Remove requirement to have poetry installed for GSP im… #1186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thvasilo
added
gsprocessing
jalencato
reviewed
Feb 22, 2025
| LATEST_VERSION=${VERSION} | ||
| REGION=$(aws configure get region) || REGION="" | ||
| REGION=${REGION:-us-west-2} |
There was a problem hiding this comment.
I remember we add this for the case that aws configure does not have default region, common case when we launched a new EC2 instance. May we test on this case?
There was a problem hiding this comment.
So before if a user did not have a region configured and did not provide a region, the script would push the image to us-west-2 by default.
I'm not sure if that's a good guess on the behalf of the customer though, so I thought we'd do this and error out instead of assuming us-west-2.
There was a problem hiding this comment.
Then let us add a comment here to highlight this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…age push script
Issue #, if available:
Description of changes:
graphstorm-processing/docker/, doing a version-aware sort and selecting the last directory name (e.g. base name of graphstorm-processing/docker/0.4.1 -> 0.4.1)By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.