[Fix] Fix an HGT Encoder Corner Case: 0 edge in a block #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhjwy9343
added
enhancement
RonaldBXu
reviewed
Feb 28, 2025
classicsong
reviewed
Feb 28, 2025
yes, will add new unit test for this corner case. |
RonaldBXu
reviewed
Feb 28, 2025
Co-authored-by: RonaldBXu <[email protected]>
classicsong
reviewed
Feb 28, 2025
added 3 commits
February 28, 2025 23:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR fixes an HGT Encoder corner case, where the edge type with feature has 0 edge in a block. In such case the input of edge feature become empty dict, and will trigger an assertion error in the previous implementation. This PR handles this corner case.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.