refactor: SDK model loading #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weibenz1
approved these changes
Dec 4, 2025
iam-policy-autopilot-policy-generation/src/extraction/javascript/shared.rs
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Some cleanup in data loading: Moving to a setup, where the
...Rawstructs have the raw embedded data, and the...Datastructs provide views on top of raw data. I think this separation makes sense, as we sometimes combine data from multiple files, and consumers of the data should not need to know which file it comes from.This also gets us a step closer to ensuring we load data into memory only once.
Also removed
WaitersRegistryand usedserde_jsondirectly instead of theJsonProvider. If we decide to add a Wasm compilation target, we will need to revisit this.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.