refactor: remove waiters from SdkServiceDefinition #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpaco-aws
reviewed
Dec 15, 2025
iam-policy-autopilot-policy-generation/src/extraction/python/waiters_extractor.rs
Outdated
Show resolved
Hide resolved
iam-policy-autopilot-policy-generation/src/extraction/python/waiters_extractor.rs
Outdated
Show resolved
Hide resolved
iam-policy-autopilot-policy-generation/src/extraction/typescript/extractor.rs
Show resolved
Hide resolved
mschlaipfer
force-pushed
the
refactor-waiters
branch
from
ae9c312 to
0d53f60
Compare
mschlaipfer
force-pushed
the
refactor-waiters
branch
from
5e364a3 to
2dc29c2
Compare
mschlaipfer
force-pushed
the
refactor-waiters
branch
from
2dc29c2 to
0de3a74
Compare
mschlaipfer
commented
Dec 18, 2025
| receiver: Option<String>, | ||
| ) -> Vec<SdkMethodCall> { | ||
| // Convert Python snake_case waiter name to PascalCase for lookup | ||
| let waiter_name_pascal = waiter_info.waiter_name.to_case(Case::Pascal); |
Contributor
Author
There was a problem hiding this comment.
This conversion here was wrong, fixed it as part of this PR. See #89
adpaco-aws
approved these changes
Dec 18, 2025
karanjitsingh
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Stores the waiter model the same as "regular" method calls by introducing
waiter_lookupinServiceModelIndex, removing the need for a two-step service name and then waiter definition lookup. Also removes some duplication in the synthetic call generation related to waiters by introducingcreate_synthetic_call_internal.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.