feat: read only mode as a security guardrail (#92) #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschlaipfer
requested changes
Dec 19, 2025
| let tools: Vec<Tool> = if self.read_only { | ||
| all_tools | ||
| .into_iter() | ||
| .filter(|tool| tool.name.as_ref() != "fix_access_denied") |
Contributor
There was a problem hiding this comment.
Instead of filtering by name, would it make sense for the tools to have a property against we filter?
| } | ||
|
|
||
| pub async fn start_mcp_server(transport: McpTransport, port: u16) -> Result<()> { | ||
| pub async fn start_mcp_server(transport: McpTransport, port: u16, read_only: bool) -> Result<()> { |
Contributor
There was a problem hiding this comment.
Instead of passing individual booleans, let's introduce a configuration object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #92
Description of changes:
Introduces
--read-onlyflag as a security guardrail. currentlyfix_access_deniedis the only tool that mutates policies in customer's account, we should simply disable this tool if read-only flag is set, sincegenerate_policy_for_access_deniedalready exists, no need for custom logic withinfix_access_deniedBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.