-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(ecs-mcp-server): add AWS Knowledge MCP Server proxy integration #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
guitar80ep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Directionally, it all looks correct. My comment areas:
- Can we provide a signal in the tools doc to the LLM that this proxy is duplicative if the customer has the AWS KB MCP installed? It’s not the end of the world to repeat work, but it’s less than ideal
- will we plan to update the prompts on any new release?
- What kinds of manual tests did we do?
Smaller comments:
- did we have to do the main.py refactor in this CR?
- Any best practices for Fast MCP Proxy that we discovered?
src/ecs-mcp-server/awslabs/ecs_mcp_server/modules/aws_knowledge_proxy.py
Show resolved
Hide resolved
src/ecs-mcp-server/awslabs/ecs_mcp_server/modules/aws_knowledge_proxy.py
Show resolved
Hide resolved
src/ecs-mcp-server/awslabs/ecs_mcp_server/modules/aws_knowledge_proxy.py
Show resolved
Hide resolved
|
1. Can we provide a signal in the tools doc to the LLM that this proxy is duplicative if the customer has the AWS KB MCP installed? 2. will we plan to update the prompts on any new release? 3. What kinds of manual tests did we do? 4. did we have to do the main.py refactor in this CR? 5. Any best practices for Fast MCP Proxy that we discovered?** |
eaebb13 to
7191c6a
Compare
guitar80ep
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved! We can iterate from here - but I think we have raised the bar for testing compared to previous CRs. In addition, it'll be nice to get this in the hands of customers to see what other feedback we should address.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1332 +/- ##
==========================================
- Coverage 89.40% 88.90% -0.50%
==========================================
Files 708 460 -248
Lines 49392 26992 -22400
Branches 7748 4316 -3432
==========================================
- Hits 44160 23998 -20162
+ Misses 3398 1932 -1466
+ Partials 1834 1062 -772 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
Integrate AWS Knowledge MCP Server as a proxy to provide up-to-date AWS documentation access, including new ECS features beyond standard LLM training data. Add tool transformations to append ECS-specific guidance and register prompt patterns for new features.
Changes
User experience
Customers can retrieve up-to-date ECS documentation, best practices, and knowledge of new tools that models may not be trained on, such as Blue-Green deployments.
Testing
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change? (Y/N) N
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.