Merged
Conversation
After #72, our file connector will be running in background by default. This breaks the benchmark clean up process because we're now using the wrong pid to kill the process after unmount. Technically, running in background should not be a problem but because of #93 we will have to use `--foreground` flag until we have it fixed. Signed-off-by: Monthon Klongklaew <monthonk@amazon.co.uk>
monthonk
force-pushed
the
fix_benchmark
branch
from
9f31c5b to
69da683
Compare
dannycjones
requested changes
Feb 16, 2023
Signed-off-by: Monthon Klongklaew <monthonk@amazon.co.uk>
dannycjones
approved these changes
Feb 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #72, we have changed the FS name to
s3-file-connectorand our file connector will be running in background by default. This breaks the benchmark clean up process because we're now using the wrong pid to kill the process after unmount.Technically, running in background should not be a problem but because of #93 we will have to use
--foregroundflag until we have it fixed.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.