-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CRT submodules to latest #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just need confirmation on manual test for --profile <PROFILE_NAME>
fix (and Clippy appeasement).
Signed-off-by: Burak Varlı <[email protected]>
Also confirmed $ cat ~/.aws/config
[profile personal]
credential_process=...
$ mount-s3 --version
mount-s3 1.8.0
$ mount-s3 bucket-name /tmp/mnt --profile personal
Error: Failed to create S3 client
Caused by:
0: initial ListObjectsV2 failed for bucket bucket-name in region us-east-1
1: Client error
2: No signing credentials found
Error: Failed to create mount process
$ ./target/release/mount-s3 bucket-name /tmp/mnt --profile personal
bucket bucket-name is mounted at /tmp/mnt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, bar one nit
Co-authored-by: Daniel Carl Jones <[email protected]> Signed-off-by: Burak <[email protected]>
Description of change
Notably, includes the following fixes:
--profile
does not correctly usecredential_process
(Appstream) #389CRT changelog:
Does this change impact existing behavior?
Does this change need a changelog entry in any of the crates?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).