Remove join function which appends region to S3 bucket name. #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarified S3 bucket name
Removed the requirement to include the aws region in the S3 bucket name to make deployment easier and the process clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The released version requires the user to create an S3 bucket in order to deploy the lambda however the cloudformation template then appends this s3 bucket name with the region the code is deployed in. This is not made clear in the documentation. There is no good reason to do this and the lack of clarity in the readme means that this can be a blocker to deploying the code.
cloudformation/speke_reference.json - removed join function which appends the S3 bucket name with the region.
Updated readme.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.