Added immutability check to change install variables - #18
Open
secretmango wants to merge 6 commits into
Open
Conversation
This was pretty easy. Everything sets up normally, even though the main program still has some hardcoded mutable-OS dependencies. If the system is mutable, everything will stay the same
Unsure about the polkit rules. The immutable version is work in progress, the current way is unchanged, again. Afaik one should not write polkit rules to /usr but to /etc in general
also used the python version of immutability detection. Looks good to me, should be checked.
not needed
this should just work normally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was pretty easy. Everything sets up normally, even though the main program still has some hardcoded mutable-OS dependencies.
If the system is mutable, everything will stay the same