chore(minor)!: configure clippy arithmetic lints in cargo.toml (#300)

* add workspace lints * add comment
axelarnetwork · Mar 15, 2024 · 27e1abf · 27e1abf
1 parent f0f58b9
commit 27e1abf
Show file tree

Hide file tree

Showing 22 changed files with 66 additions and 6 deletions.
diff --git a/.github/workflows/basic.yaml b/.github/workflows/basic.yaml
@@ -20,7 +20,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.73.0
+          toolchain: 1.75.0
           override: true
 
       - name: Install protoc
@@ -52,7 +52,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.73.0
+          toolchain: 1.75.0
           target: wasm32-unknown-unknown
           override: true
 
@@ -88,7 +88,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.73.0
+          toolchain: 1.75.0
           override: true
           components: rustfmt, clippy
 
@@ -123,7 +123,7 @@ jobs:
         uses: actions-rs/cargo@v1
         with:
           command: clippy
-          args: -- -D warnings -A deprecated
+          args: -- -D warnings -A deprecated -D clippy::arithmetic_side_effects
 
       - name: Check Diff
         # fails if any changes not committed

diff --git a/.github/workflows/codecov.yaml b/.github/workflows/codecov.yaml
@@ -19,7 +19,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.73.0
+          toolchain: 1.75.0
           override: true
 
       - name: Install protoc

diff --git a/Cargo.toml b/Cargo.toml
@@ -3,7 +3,7 @@ members = ["ampd", "contracts/*", "integration-tests", "packages/*"]
 resolver = "2"
 
 [workspace.package]
-rust-version = "1.73.0"
+rust-version = "1.75.0" # be sure there is an optimizer release supporting this version before updating. See https://github.com/CosmWasm/optimizer
 
 [workspace.dependencies]
 connection-router = { version = "^0.1.0", path = "contracts/connection-router" }
@@ -36,6 +36,9 @@ schemars = "0.8.10"
 sha3 = { version = "0.10.8", default-features = false, features = [] }
 signature-verifier-api = { version = "^0.1.0", path = "packages/signature-verifier-api" }
 
+[workspace.lints.clippy]
+arithmetic_side_effects = "deny"
+
 [profile.release]
 opt-level = 3
 debug = false

diff --git a/ampd/Cargo.toml b/ampd/Cargo.toml
@@ -74,3 +74,6 @@ random-string = "1.0.0"
 [build-dependencies]
 ethers = "2.0.8"
 tonic-build = "0.8.3"
+
+[lints]
+workspace = true
diff --git a/contracts/aggregate-verifier/Cargo.toml b/contracts/aggregate-verifier/Cargo.toml
@@ -53,3 +53,6 @@ voting-verifier = { workspace = true, features = ["library"] }
 [dev-dependencies]
 cw-multi-test = "0.15.1"
 integration-tests = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/contracts/connection-router/Cargo.toml b/contracts/connection-router/Cargo.toml
@@ -58,3 +58,6 @@ cw-multi-test = "0.15.1"
 hex = { version = "0.4.3", default-features = false }
 integration-tests = { workspace = true }
 rand = "0.8.5"
+
+[lints]
+workspace = true
diff --git a/contracts/gateway/Cargo.toml b/contracts/gateway/Cargo.toml
@@ -55,3 +55,6 @@ thiserror = { workspace = true }
 
 [dev-dependencies]
 cw-multi-test = "0.15.1"
+
+[lints]
+workspace = true
diff --git a/contracts/multisig-prover/Cargo.toml b/contracts/multisig-prover/Cargo.toml
@@ -66,3 +66,6 @@ cw-multi-test = "0.15.1"
 elliptic-curve = "0.13.5"
 ethers = "2.0.8"
 generic-array = "0.14.7"
+
+[lints]
+workspace = true
diff --git a/contracts/multisig/Cargo.toml b/contracts/multisig/Cargo.toml
@@ -62,3 +62,6 @@ thiserror = { workspace = true }
 
 [dev-dependencies]
 cw-multi-test = "0.15.1"
+
+[lints]
+workspace = true
diff --git a/contracts/nexus-gateway/Cargo.toml b/contracts/nexus-gateway/Cargo.toml
@@ -26,3 +26,6 @@ report = { workspace = true }
 schemars = "0.8.15"
 serde = { version = "1.0.188", features = ["derive"] }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/contracts/rewards/Cargo.toml b/contracts/rewards/Cargo.toml
@@ -48,3 +48,6 @@ thiserror = { workspace = true }
 
 [dev-dependencies]
 cw-multi-test = "0.15.1"
+
+[lints]
+workspace = true
diff --git a/contracts/service-registry/Cargo.toml b/contracts/service-registry/Cargo.toml
@@ -50,3 +50,6 @@ thiserror = { workspace = true }
 [dev-dependencies]
 cw-multi-test = "0.15.1"
 integration-tests = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/contracts/voting-verifier/Cargo.toml b/contracts/voting-verifier/Cargo.toml
@@ -54,3 +54,6 @@ thiserror = { workspace = true }
 [dev-dependencies]
 cw-multi-test = "0.15.1"
 integration-tests = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/integration-tests/Cargo.toml b/integration-tests/Cargo.toml
@@ -57,3 +57,6 @@ sha3 = { workspace = true }
 thiserror = { workspace = true }
 tofn = { git = "https://github.com/axelarnetwork/tofn.git", branch = "update-deps" }
 voting-verifier = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/packages/axelar-wasm-std-derive/Cargo.toml b/packages/axelar-wasm-std-derive/Cargo.toml
@@ -15,3 +15,6 @@ quote = "1.0.33"
 report = { workspace = true }
 syn = "2.0.29"
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/packages/axelar-wasm-std/Cargo.toml b/packages/axelar-wasm-std/Cargo.toml
@@ -49,3 +49,6 @@ valuable = { version = "0.1.0", features = ["derive"] }
 cw-multi-test = "0.15.1"
 hex = { version = "0.4.3", default-features = false }
 rand = "0.8.5"
+
+[lints]
+workspace = true
diff --git a/packages/connection-router-api/Cargo.toml b/packages/connection-router-api/Cargo.toml
@@ -25,3 +25,6 @@ valuable = "0.1.0"
 [dev-dependencies]
 hex = "0.4.3"
 rand = "0.8.5"
+
+[lints]
+workspace = true
diff --git a/packages/events-derive/Cargo.toml b/packages/events-derive/Cargo.toml
@@ -15,3 +15,6 @@ quote = "1.0.33"
 serde = "1.0.183"
 serde_json = "1.0.105"
 syn = "2.0.29"
+
+[lints]
+workspace = true
diff --git a/packages/events/Cargo.toml b/packages/events/Cargo.toml
@@ -16,3 +16,6 @@ serde_json = "1.0.105"
 # The fix for the issue is at https://github.com/axelarnetwork/tendermint-rs/commit/e97033e20e660a7e707ea86db174ec047bbba50d.
 tendermint = { git = "https://github.com/axelarnetwork/tendermint-rs.git", branch = "v0.33.x" }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/packages/gateway-api/Cargo.toml b/packages/gateway-api/Cargo.toml
@@ -8,3 +8,6 @@ edition = "2021"
 [dependencies]
 connection-router-api ={ workspace = true }
 cosmwasm-schema = { workspace = true }
+
+[lints]
+workspace = true
diff --git a/packages/report/Cargo.toml b/packages/report/Cargo.toml
@@ -11,3 +11,6 @@ eyre = "0.6.8"
 itertools = { workspace = true }
 thiserror = { workspace = true }
 valuable = { version = "0.1.0", features = ["derive"] }
+
+[lints]
+workspace = true
diff --git a/packages/signature-verifier-api/Cargo.toml b/packages/signature-verifier-api/Cargo.toml
@@ -10,3 +10,6 @@ cosmwasm-std = { workspace = true }
 cosmwasm-storage = { workspace = true }
 error-stack = { workspace = true }
 thiserror = { workspace = true }
+
+[lints]
+workspace = true